Welcome, Guest
Username Password: Remember me

stopforumspam.com
(1 viewing) (1) Guest
  • Page:
  • 1

TOPIC: stopforumspam.com

stopforumspam.com 2 years, 4 months ago #501

  • etusha
  • OFFLINE
  • Fresh Boarder
  • http://www.Lundro.AL
  • Posts: 5
  • Karma: 0
i have upgrate to latest version that have integrate stopforumspam.com
i use Yes (reject only IP AND email match)

no new user for more than a week
i have try to create a account by my self

and stopforumspam.com blocked IP

MY IP BLOCKED ??????

i suggest remove it

Re:stopforumspam.com 2 years, 4 months ago #502

That's odd, I have it enabled on my site and have no problems.

Presumably you can just disable it in the plugin options and it solves the issue?

It may be that there is a problem reaching stopforumspam - I will double-check the plugin to ensure that in the case of it failing to get a valid result, it allows the registration.

Re:stopforumspam.com 2 years, 4 months ago #503

  • etusha
  • OFFLINE
  • Fresh Boarder
  • http://www.Lundro.AL
  • Posts: 5
  • Karma: 0
i can secure u about it
because at the moment i disable it i have new user

Re:stopforumspam.com 2 years, 4 months ago #504

Please try the attached modification. I have put more checking of the response from StopForumSpam, it should disregard any data if it is invalid. I can't test it though, as I don't appear to be having any issues currently.
Attachments:
Last Edit: 2 years, 2 months ago by purplepomegranite.

Re:stopforumspam.com 2 years, 4 months ago #505

  • etusha
  • OFFLINE
  • Fresh Boarder
  • http://www.Lundro.AL
  • Posts: 5
  • Karma: 0
sorry i cant test it i have a site with traffic

Re:stopforumspam.com 2 years, 4 months ago #506

Ok, but I can't release a fix until it is tested against a site with issues. My site is working fine (as is my test site), so I can't test at all.

Re:stopforumspam.com 2 years, 4 months ago #507

  • etusha
  • OFFLINE
  • Fresh Boarder
  • http://www.Lundro.AL
  • Posts: 5
  • Karma: 0
Do u have any test site or u use cedit.biz for testing

if u have any test site i like to try

Re:stopforumspam.com 2 years, 4 months ago #508

Yes, I have a test site. But the problem is, I don't have/can't replicate the issue you have had with the StopForumSpam part so there is no point in testing on my site. The changes need to be tested on a site that had issues.

Re:stopforumspam.com 2 years, 1 month ago #714

  • darjk
  • OFFLINE
  • Fresh Boarder
  • Posts: 1
  • Karma: 0
I know this is an old thread but having the exact same issue with version 1.2.7 of the plugin.

I also have it set to "Yes (reject only IP AND email match)" and it then appears to block everyone who registers even though there is NO matches what so ever.

About to try it with the "Yes (reject any match)" setting.

Using the above forementioned setting works as intended, but its definitely a bug with the other setting. Going to look at the source of the plugin now to see if its a simple syntax error in how its comparing the values.

Edit:
Okay on line 448 of cedit_blockdisposable.php it has
if ( ( $emailbad && $ipbad ) || ( $count = 2 ) ) return true;


Isn't that always going to return true? Shouldn't it be
if ( ( $emailbad && $ipbad ) || ( $count == 2 ) ) return true;


I'm not a PHP programmer (my primary cup of tea is C / C++) so there could be minor differences in syntax between the languages, so I could be wrong. However I know in C that is indeed a minor but critical bug (made the mistake in the past in a project).
Last Edit: 2 years, 1 month ago by darjk.

Re:stopforumspam.com 2 years, 1 month ago #715

  • admin
  • OFFLINE
  • Administrator
  • Posts: 11
  • Karma: 1
You are absolutely right, thanks for spotting this and reporting it. That statement will always return true, so if StopForumSpam is enabled on both IP and email match, all registrations will be rejected. The default for Registration Validator is to reject on either match - that part of the code doesn't contain a bug, so anyone leaving RV in its default configuration would not have the problem.

I'll post a bugfix immediately.

Re:stopforumspam.com 2 years, 1 month ago #716

I've just reread the original post in the thread. I completely missed the mention of setting it to check IP AND email, which is why I didn't replicate the problem. Sorry for that - the fixed version is now uploaded.

Re:stopforumspam.com 2 years, 1 month ago #717

  • bdcomp
  • OFFLINE
  • Fresh Boarder
  • Posts: 1
  • Karma: 0
Can you please told for how long this bug exist?
From that version of RV?

On my site there no registrations for last several days, so I wanna to understand if there some correlation to RV...

Re:stopforumspam.com 2 years, 1 month ago #718

This bug will have been in every version of Registration Validator since StopForumSpam check was implemented.

Note that under default configuration registrations wouldn't be blocked - there is only an issue if you change the StopForumSpam setting to block only when both IP address AND email address are listed at StopForumSpam (default configuration is to block if either are listed).

If your plugin is set to reject only if StopForumSpam if both match, then that will be the problem for your registrations. If you haven't changed this setting, then you won't have the problem.
  • Page:
  • 1
Time to create page: 3.75 seconds
Copyright © 2009 www.cedit.biz. All rights reserved.